netdev - Re: [PATCH net-next 1/7] net: phy: mdio-bcm-unimac: factor busy polling loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Aug 2017 08:28:06 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
        opendmb@...il.com, jaedon.shin@...il.com, pgynther@...gle.com,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 1/7] net: phy: mdio-bcm-unimac: factor busy
 polling loop

Hi Florian,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-bcmgenet-utilize-MDIO-unimac-driver/20170801-075847
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

Note: the linux-review/Florian-Fainelli/net-bcmgenet-utilize-MDIO-unimac-driver/20170801-075847 HEAD 68043f6ab1b54d29abc5555fc56fdec46d280b76 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/net/phy/mdio-bcm-unimac.c: In function 'unimac_mdio_read':
>> drivers/net/phy/mdio-bcm-unimac.c:89:2: error: 'ret' undeclared (first use in this function)
     ret = unimac_mdio_poll(priv);
     ^
   drivers/net/phy/mdio-bcm-unimac.c:89:2: note: each undeclared identifier is reported only once for each function it appears in

vim +/ret +89 drivers/net/phy/mdio-bcm-unimac.c

    76	
    77	static int unimac_mdio_read(struct mii_bus *bus, int phy_id, int reg)
    78	{
    79		struct unimac_mdio_priv *priv = bus->priv;
    80		u32 cmd;
    81	
    82		/* Prepare the read operation */
    83		cmd = MDIO_RD | (phy_id << MDIO_PMD_SHIFT) | (reg << MDIO_REG_SHIFT);
    84		__raw_writel(cmd, priv->base + MDIO_CMD);
    85	
    86		/* Start MDIO transaction */
    87		unimac_mdio_start(priv);
    88	
  > 89		ret = unimac_mdio_poll(priv);
    90		if (ret)
    91			return ret;
    92	
    93		cmd = __raw_readl(priv->base + MDIO_CMD);
    94	
    95		/* Some broken devices are known not to release the line during
    96		 * turn-around, e.g: Broadcom BCM53125 external switches, so check for
    97		 * that condition here and ignore the MDIO controller read failure
    98		 * indication.
    99		 */
   100		if (!(bus->phy_ignore_ta_mask & 1 << phy_id) && (cmd & MDIO_READ_FAIL))
   101			return -EIO;
   102	
   103		return cmd & 0xffff;
   104	}
   105	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50916 bytes)