netdev - [PATCH] ATM-nicstar: Delete an error message for a failed memory allocation in ns_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 6 Aug 2017 10:16:54 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
        Chas Williams <3chas3@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] ATM-nicstar: Delete an error message for a failed memory
 allocation in ns_init_card()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sun, 6 Aug 2017 10:10:21 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/atm/nicstar.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index 9588d80f318e..08d5aa8b9524 100644
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -372,9 +372,6 @@ static int ns_init_card(int i, struct pci_dev *pcidev)
 
 	card = kmalloc(sizeof(*card), GFP_KERNEL);
 	if (!card) {
-		printk
-		    ("nicstar%d: can't allocate memory for device structure.\n",
-		     i);
 		error = 2;
 		ns_init_card_error(card, error);
 		return error;
-- 
2.13.4