lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Aug 2017 09:59:04 -0600 From: David Ahern <dsahern@...il.com> To: Phil Sutter <phil@....cc>, Stephen Hemminger <stephen@...workplumber.org> Cc: netdev@...r.kernel.org Subject: Re: [iproute PATCH 14/51] ipvrf: Don't try to close an invalid fd On 8/12/17 6:04 AM, Phil Sutter wrote: > Signed-off-by: Phil Sutter <phil@....cc> > --- > ip/ipvrf.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/ip/ipvrf.c b/ip/ipvrf.c > index 0094cf8557cd7..92e2db98ca7d7 100644 > --- a/ip/ipvrf.c > +++ b/ip/ipvrf.c > @@ -268,7 +268,7 @@ static int vrf_configure_cgroup(const char *path, int ifindex) > fprintf(stderr, > "Failed to open cgroup path: '%s'\n", > strerror(errno)); > - goto out; > + return rc; > } > > /* > @@ -290,13 +290,14 @@ static int vrf_configure_cgroup(const char *path, int ifindex) > if (bpf_prog_attach_fd(prog_fd, cg_fd, BPF_CGROUP_INET_SOCK_CREATE)) { > fprintf(stderr, "Failed to attach prog to cgroup: '%s'\n", > strerror(errno)); > - goto out; > + goto out2; > } > > rc = 0; > +out2: > + close(prog_fd); > out: > close(cg_fd); > - close(prog_fd); > > return rc; > } > Acked-by: David Ahern <dsahern@...il.com>
Powered by blists - more mailing lists