netdev - Re: ipv4: distinguish EHOSTUNREACH from the ENETUNREACH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2017 13:35:24 -0700
From:   Daniel Walker <danielwa@...co.com>
To:     Duan Jiong <duanj.fnst@...fujitsu.com>,
        "David S. Miller" <davem@...emloft.net>,
        Poornima Ranganath <pooranga@...co.com>,
        xe-linux-external@...co.com, netdev@...r.kernel.org
Subject: Re: ipv4: distinguish EHOSTUNREACH from the ENETUNREACH

Hi,

It seems like commit cd0f0b is trying to add back these two errors 
values into ip_route_input_slow(). However, if you follow the code path 
further down you get to the two exit points of this function,

in net/ipv4/route.c:ip_route_input_slow()

if (rt_cache_valid(rth)) {
	skb_dst_set_noref(skb, &rth->dst);
	err = 0;
	goto out;
}

and

skb_dst_set(skb, &rth->dst);
err = 0;
goto out;

Both of these set "err" variable to 0. This effective destroys the 
return value which the patch seems to be adding. Am I missing something 
here?

Thanks,

Daniel