netdev - Re: [PATCH 3/6] mpls: add VPLS entry points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2017 18:13:42 +0200
From:   Amine Kherbouche <amine.kherbouche@...nd.com>
To:     David Lamparter <equinox@...c24.net>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH 3/6] mpls: add VPLS entry points



On 08/21/2017 05:55 PM, David Lamparter wrote:
>>> +	if (rt->rt_payload_type == MPT_VPLS)
>>> > > +		return vpls_rcv(skb, dev, pt, rt, hdr, orig_dev);
>> >
>> > you should get the ret value of vpls_rcv() and increment stats if error
>> > occurs.
> An error in vpls_rcv() is not a receive error on the outer device's MPLS
> layer;  the packet was received correctly (and counted for that at the
> beginning of mpls_forward()) and dispatched onto an appropriately
> configured VPLS device.  vpls_rcv() counts its own stats on the inner
> device.

Right.