netdev - Re: [PATCH] dt-binding: net/phy: fix interrupts description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2017 13:20:39 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     devicetree@...r.kernel.org, netdev@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] dt-binding: net/phy: fix interrupts description

Hi Dave,

On Wed, Aug 23, 2017 at 09:11:00AM +0300, Baruch Siach wrote:
> Commit b053dc5a722ea (powerpc: Refactor device tree binding) split the
> Ethernet PHY binding documentation out of the big booting-without-of.txt
> file, leaving a dangling reference to "section 2" in the 'interrupts'
> property description. Drop that reference, and make the description look
> more like the rest.
> 
> While at it, make the example interrupt-parent phandle look more like a
> real world phandle, and use an IRQ_TYPE_ macro for the 'interrupts'
> type.

This patch is now marked 'Not Applicable' in the netdev patchwork. Why is 
that? Should it go through some other tree?

baruch

> Signed-off-by: Baruch Siach <baruch@...s.co.il>
> ---
>  Documentation/devicetree/bindings/net/phy.txt | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt
> index b55857696fc3..86ba72af6163 100644
> --- a/Documentation/devicetree/bindings/net/phy.txt
> +++ b/Documentation/devicetree/bindings/net/phy.txt
> @@ -2,11 +2,7 @@ PHY nodes
>  
>  Required properties:
>  
> - - interrupts : <a b> where a is the interrupt number and b is a
> -   field that represents an encoding of the sense and level
> -   information for the interrupt.  This should be encoded based on
> -   the information in section 2) depending on the type of interrupt
> -   controller you have.
> + - interrupts : interrupt specifier for the sole interrupt.
>   - interrupt-parent : the phandle for the interrupt controller that
>     services interrupts for this device.
>   - reg : The ID number for the phy, usually a small integer
> @@ -56,7 +52,7 @@ Example:
>  
>  ethernet-phy@0 {
>  	compatible = "ethernet-phy-id0141.0e90", "ethernet-phy-ieee802.3-c22";
> -	interrupt-parent = <40000>;
> -	interrupts = <35 1>;
> +	interrupt-parent = <&PIC>;
> +	interrupts = <35 IRQ_TYPE_EDGE_RISING>;
>  	reg = <0>;
>  };

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -