lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 03 Sep 2017 10:55:48 -0700 (PDT) From: David Miller <davem@...emloft.net> To: sd@...asysnail.net Cc: sbrivio@...hat.com, netdev@...r.kernel.org, weiwan@...gle.com Subject: Re: [PATCH net] ipv4: Don't override return code from ip_route_input_noref() From: Sabrina Dubroca <sd@...asysnail.net> Date: Fri, 1 Sep 2017 01:45:06 +0200 > 2017-08-31, 18:11:41 +0200, Stefano Brivio wrote: >> After ip_route_input() calls ip_route_input_noref(), another >> check on skb_dst() is done, but if this fails, we shouldn't >> override the return code from ip_route_input_noref(), as it >> could have been more specific (i.e. -EHOSTUNREACH). >> >> This also saves one call to skb_dst_force_safe() and one to >> skb_dst() in case the ip_route_input_noref() check fails. >> >> Reported-by: Sabrina Dubroca <sdubroca@...hat.com> >> Fixes: ad65a2f05695 ("ipv4: call dst_hold_safe() properly") > > That should be instead: > > Fixes: 9df16efadd2a ("ipv4: call dst_hold_safe() properly") > > Acked-by: Sabrina Dubroca <sd@...asysnail.net> Applied with fixed Fixes: tag, thanks.
Powered by blists - more mailing lists