netdev - Re: [PATCH] bgmac: Remove all offloading features, including GRO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Sep 2017 16:55:28 -0700
From:   rosenp@...il.com
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, zajec5@...il.com, nbd@....name
Subject: Re: [PATCH] bgmac: Remove all offloading features, including GRO.

you're absolutely correct. will send an updated version shortly.

On Fri, 2017-09-15 at 16:14 -0700, David Miller wrote:
> From: Rosen Penev <rosenp@...il.com>
> Date: Fri, 15 Sep 2017 15:22:18 -0700
> 
> > On a linksys E1200v1 (actually a crossflashed E1000v2), the
> offloading features give no measurable benefit to speed or latency.
> Furthermore, disabling GRO actually improves iperf performance by a
> whoppimg 3mbps. Results:
>  ...
> > -     net_dev->features = NETIF_F_SG | NETIF_F_IP_CSUM |
> NETIF_F_IPV6_CSUM;
> > +     net_dev->features &= NETIF_F_GRO;
> >       net_dev->hw_features = net_dev->features;
> 
> This doesn't disable GRO.