netdev - Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2017 13:47:27 +0900
From:   Erik Kline <ek@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     mcroce@...hat.com, netdev <netdev@...r.kernel.org>,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

> Erik, please review.

I apologize for the delay. I see that you've already applied this, and
it's mostly LGTM except I have one thing I'm not seeing clearly.

The documentation accept_dad  now claims:

    DAD operation and mode on a given interface will be selected according
    to the maximum value of conf/{all,interface}/accept_dad.

but I'm try to square this with my reading of the changes to
addrconf_dad_begin().  I think setting all.accept_dad to 0 but
ifname.accept_dad to non-0 still results in the short-circuit call to
addrconf_dad_completed().

Am I just not seeing (thinking) straight?

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4835 bytes)