lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 Sep 2017 14:10:31 +0800 From: Yunsheng Lin <linyunsheng@...wei.com> To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>, <davem@...emloft.net>, <lipeng321@...wei.com>, <colin.king@...onical.com>, <arnd@...db.de> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH] net: hns3: Fix an error handling path in 'hclge_rss_init_hw()' Hi, Christophe On 2017/9/30 13:34, Christophe JAILLET wrote: > If this sanity check fails, we must free 'rss_indir'. Otherwise there is a > memory leak. > 'goto err' as done in the other error handling paths to fix it. Thanks for fixing. > > Fixes: 46a3df9f9718 ("net: hns3: Fix for setting rss_size incorrectly") > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > --- > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > index e0685e630afe..c1cdbfd83bdb 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > @@ -2652,7 +2652,8 @@ static int hclge_rss_init_hw(struct hclge_dev *hdev) > dev_err(&hdev->pdev->dev, > "Configure rss tc size failed, invalid TC_SIZE = %d\n", > rss_size); > - return -EINVAL; > + ret = -EINVAL; > + goto err; > } > > roundup_size = roundup_pow_of_two(rss_size); >
Powered by blists - more mailing lists