netdev - Re: [PATCH 1/4] dt-bindings: net: ravb: Document optional reset-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2017 18:24:51 -0500
From:   Rob Herring <robh@...nel.org>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        "David S . Miller" <davem@...emloft.net>,
        Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: net: ravb: Document optional
 reset-gpios property

On Thu, Sep 28, 2017 at 11:07:38PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 09/28/2017 06:53 PM, Geert Uytterhoeven wrote:
> 
> > The optional "reset-gpios" property (part of the generic MDIO bus
> > properties) lets us describe the GPIO used for resetting the Ethernet
> > PHY.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> >   Documentation/devicetree/bindings/net/renesas,ravb.txt | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index c902261893b913f5..4a6ec1ba32d0bf16 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -52,6 +52,7 @@ Optional properties:
> >   			 AVB_LINK signal.
> >   - renesas,ether-link-active-low: boolean, specify when the AVB_LINK signal is
> >   				 active-low instead of normal active-high.
> > +- reset-gpios: see mdio.txt in the same directory.
> 
>    Sigh, I can only repeat that was a terrible prop name choice -- when
> applied to a MAC node... what reset does it mean? MAC?

Agreed. This should be in the phy node. Or MDIO at least.