lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 8 Oct 2017 22:29:12 +0100 From: Christos Gkekas <chris.gekas@...il.com> To: QCA ath9k Development <ath9k-devel@....qualcomm.com>, Kalle Valo <kvalo@...eaurora.org>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Christos Gkekas <chris.gekas@...il.com> Subject: [PATCH] ath9k: debug: Simplify error checking Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas <chris.gekas@...il.com> --- drivers/net/wireless/ath/ath9k/debug.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c index 01fa301..3b93c23 100644 --- a/drivers/net/wireless/ath/ath9k/debug.c +++ b/drivers/net/wireless/ath/ath9k/debug.c @@ -1164,10 +1164,7 @@ static ssize_t write_file_tpc(struct file *file, const char __user *user_buf, return -EFAULT; buf[len] = '\0'; - if (kstrtoul(buf, 0, &val)) - return -EINVAL; - - if (val < 0 || val > 1) + if (kstrtoul(buf, 0, &val) || val > 1) return -EINVAL; tpc_enabled = !!val; -- 2.7.4
Powered by blists - more mailing lists