netdev - Re: [PATCH] timer: Remove meaningless .data/.function assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 09 Oct 2017 18:05:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     tglx@...utronix.de, khc@...waw.pl, aditya.shankar@...rochip.com,
        ganesh.krishna@...rochip.com, gregkh@...uxfoundation.org,
        axboe@...com, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] timer: Remove meaningless .data/.function assignments

From: Kees Cook <keescook@...omium.org>
Date: Mon, 9 Oct 2017 17:10:32 -0700

> Several timer users needlessly reset their .function/.data fields during
> their timer callback, but nothing else changes them. Some users do not
> use their .data field at all. Each instance is removed here.
> 
> Cc: Krzysztof Halasa <khc@...waw.pl>
> Cc: Aditya Shankar <aditya.shankar@...rochip.com>
> Cc: Ganesh Krishna <ganesh.krishna@...rochip.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jens Axboe <axboe@...com>
> Cc: netdev@...r.kernel.org
> Cc: linux-wireless@...r.kernel.org
> Cc: devel@...verdev.osuosl.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> # for staging
> Acked-by: Krzysztof Halasa <khc@...waw.pl> # for wan/hdlc*
> Acked-by: Jens Axboe <axboe@...nel.dk> # for amiflop
> ---
> This should go via the timer/core tree, please. It's been acked by each
> of the maintainers. Thanks!

For networking bits:

Acked-by: David S. Miller <davem@...emloft.net>