netdev - Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 09:59:39 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Brandon Streiff <brandon.streiff@...com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

Hi Brandon,

Vivien Didelot <vivien.didelot@...oirfairelinux.com> writes:

> Brandon Streiff <brandon.streiff@...com> writes:
>
>> +	.port_ptp_read		= mv88e6352_port_ptp_read,
>> +	.port_ptp_write		= mv88e6352_port_ptp_write,
>> +	.ptp_read		= mv88e6352_ptp_read,
>> +	.ptp_write		= mv88e6352_ptp_write,
>> +	.tai_read		= mv88e6352_tai_read,
>> +	.tai_write		= mv88e6352_tai_write,
>
>> +	.port_ptp_read		= mv88e6390_port_ptp_read,
>> +	.port_ptp_write		= mv88e6390_port_ptp_write,
>> +	.ptp_read		= mv88e6390_ptp_read,
>> +	.ptp_write		= mv88e6390_ptp_write,
>> +	.tai_read		= mv88e6390_tai_read,
>> +	.tai_write		= mv88e6390_tai_write,
>
> Only nitpick: please keep the mv88e63{52,90}_g2_avb_ prefix here.
>
> Otherwise thanks for respecting the code organization, very clear patch:
>
> Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Also feel free to move the mv88e6*_g2_avb_ functions into a
global2_avb.c file.

Thank you,

      Vivien