netdev - Re: [next-queue PATCH v5 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2017 08:58:09 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Cc:     netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
        jhs@...atatu.com, xiyou.wangcong@...il.com, andre.guedes@...el.com,
        ivan.briano@...el.com, jesus.sanchez-palencia@...el.com,
        boon.leong.ong@...el.com, richardcochran@...il.com,
        henrik@...tad.us, levipearson@...il.com, rodney.cummings@...com
Subject: Re: [next-queue PATCH v5 3/5] net/sched: Introduce Credit Based
 Shaper (CBS) qdisc

Wed, Oct 11, 2017 at 02:43:58AM CEST, vinicius.gomes@...el.com wrote:
>This queueing discipline implements the shaper algorithm defined by
>the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L.
>
>It's primary usage is to apply some bandwidth reservation to user
>defined traffic classes, which are mapped to different queues via the
>mqprio qdisc.
>
>Only a simple software implementation is added for now.
>
>Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
>Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com>
>---
> include/linux/netdevice.h      |   1 +
> include/net/pkt_sched.h        |   9 ++
> include/uapi/linux/pkt_sched.h |  18 +++
> net/sched/Kconfig              |  11 ++
> net/sched/Makefile             |   1 +
> net/sched/sch_cbs.c            | 305 +++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 345 insertions(+)
> create mode 100644 net/sched/sch_cbs.c
>
>diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>index 31bb3010c69b..1f6c44ef5b21 100644
>--- a/include/linux/netdevice.h
>+++ b/include/linux/netdevice.h
>@@ -775,6 +775,7 @@ enum tc_setup_type {
> 	TC_SETUP_CLSFLOWER,
> 	TC_SETUP_CLSMATCHALL,
> 	TC_SETUP_CLSBPF,
>+	TC_SETUP_CBS,
> };
> 
> /* These structures hold the attributes of xdp state that are being passed
>diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h
>index 259bc191ba59..7c597b050b36 100644
>--- a/include/net/pkt_sched.h
>+++ b/include/net/pkt_sched.h
>@@ -146,4 +146,13 @@ static inline bool is_classid_clsact_egress(u32 classid)
> 	       TC_H_MIN(classid) == TC_H_MIN(TC_H_MIN_EGRESS);
> }
> 
>+struct tc_cbs_qopt_offload {
>+	u8 enable;
>+	s32 queue;
>+	s32 hicredit;
>+	s32 locredit;
>+	s32 idleslope;
>+	s32 sendslope;

Please introduce the qdisc in one patch, then offload it in second. That
is what I requested already. 2 patches please.

[...]


>+static struct Qdisc_ops cbs_qdisc_ops __read_mostly = {
>+	.next		=	NULL,

It is already 0, no need to re-init.


>+	.id		=	"cbs",
>+	.priv_size	=	sizeof(struct cbs_sched_data),
>+	.enqueue	=	cbs_enqueue,
>+	.dequeue	=	cbs_dequeue,
>+	.peek		=	qdisc_peek_dequeued,
>+	.init		=	cbs_init,
>+	.reset		=	qdisc_reset_queue,
>+	.destroy	=	cbs_destroy,
>+	.change		=	cbs_change,
>+	.dump		=	cbs_dump,
>+	.owner		=	THIS_MODULE,
>+};