netdev - Re: [PATCH] [net] liquidio: fix timespec64_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2017 11:07:27 -0700
From:   Felix Manlunas <felix.manlunas@...ium.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Derek Chickles <derek.chickles@...iumnetworks.com>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        Felix Manlunas <felix.manlunas@...iumnetworks.com>,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>,
        "David S. Miller" <davem@...emloft.net>,
        Intiyaz Basha <intiyaz.basha@...ium.com>,
        Rick Farrington <ricardo.farrington@...ium.com>,
        VSR Burru <veerasenareddy.burru@...ium.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net] liquidio: fix timespec64_to_ns typo

On Thu, Oct 12, 2017 at 11:48:31AM +0200, Arnd Bergmann wrote:
> While experimenting with changes to the timekeeping code, I
> ran into a build error in the liquidio driver:
> 
> drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'liquidio_ptp_settime':
> drivers/net/ethernet/cavium/liquidio/lio_main.c:1850:22: error: passing argument 1 of 'timespec_to_ns' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 
> The driver had a type mismatch since it was first merged, but
> this never caused problems because it is only built on 64-bit
> architectures that define timespec and timespec64 to the same
> type.
> 
> If we ever want to compile-test the driver on 32-bit or change
> the way that 64-bit timespec64 is defined, we need to fix it,
> so let's just do it now.
> 
> Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> index 963803bc6633..eafae3eb4fed 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> @@ -1847,7 +1847,7 @@ static int liquidio_ptp_settime(struct ptp_clock_info *ptp,
>  	struct lio *lio = container_of(ptp, struct lio, ptp_info);
>  	struct octeon_device *oct = (struct octeon_device *)lio->oct_dev;
>  
> -	ns = timespec_to_ns(ts);
> +	ns = timespec64_to_ns(ts);
>  
>  	spin_lock_irqsave(&lio->ptp_lock, flags);
>  	lio_pci_writeq(oct, ns, CN6XXX_MIO_PTP_CLOCK_HI);
> -- 
> 2.9.0
> 

Thanks.

Acked-by: Felix Manlunas <felix.manlunas@...ium.com>