netdev - Re: [PATCH 2/3] bpf: Remove dead variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 20:54:36 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Richard Weinberger <richard@....at>, netdev@...r.kernel.org
CC:     linux-kernel@...r.kernel.org, ast@...nel.org
Subject: Re: [PATCH 2/3] bpf: Remove dead variable

On 10/16/2017 08:18 PM, Richard Weinberger wrote:
> task is never used in bpf_get_current_uid_gid(), kill it.
>
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>   kernel/bpf/helpers.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c
> index e8845adcd15e..511c9d522cfc 100644
> --- a/kernel/bpf/helpers.c
> +++ b/kernel/bpf/helpers.c
> @@ -131,7 +131,6 @@ const struct bpf_func_proto bpf_get_current_pid_tgid_proto = {
>
>   BPF_CALL_0(bpf_get_current_uid_gid)
>   {
> -	struct task_struct *task = current;
>   	kuid_t uid;
>   	kgid_t gid;
>
>

Needs to be squashed into patch 1/3?