netdev - Re: [PATCH v4 net] tcp/dccp: fix ireq->opt races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 21 Oct 2017 02:18:44 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v4 net] tcp/dccp: fix ireq->opt races

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 20 Oct 2017 09:04:13 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> syzkaller found another bug in DCCP/TCP stacks [1]
> 
> For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
> ireq->pktopts race"), we need to make sure we do not access
> ireq->opt unless we own the request sock.
> 
> Note the opt field is renamed to ireq_opt to ease grep games.
> 
 ...
> Fixes: e994b2f0fb92 ("tcp: do not lock listener to process SYN packets")
> Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> v4: Added the needed changes in net/ipv4/cipso_ipv4.c (and full build)
> v3: fixed the white space mangling
> v2: removed some lines from KASAN report that confuse patchwork.

Hey it compiles! :-)

Applied and queued up for -stable.