netdev - Re: [PATCH v2 net-next] selftests/bpf: fix broken build of test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Oct 2017 01:06:46 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     ast@...com
Cc:     daniel@...earbox.net, brakmo@...com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] selftests/bpf: fix broken build of
 test_maps

From: Alexei Starovoitov <ast@...com>
Date: Sun, 22 Oct 2017 10:29:06 -0700

> fix multiple build errors and warnings
> 
> 1.
> test_maps.c: In function ‘test_map_rdonly’:
> test_maps.c:1051:30: error: ‘BPF_F_RDONLY’ undeclared (first use in this function)
>         MAP_SIZE, map_flags | BPF_F_RDONLY);
> 
> 2.
> test_maps.c:1048:6: warning: unused variable ‘i’ [-Wunused-variable]
>   int i, fd, key = 0, value = 0;
> 
> 3.
> test_maps.c:1087:2: error: called object is not a function or function pointer
>   assert(bpf_map_lookup_elem(fd, &key, &value) == -1 && errno == EPERM);
> 
> 4.
> ./bpf_helpers.h:72:11: error: use of undeclared identifier 'BPF_FUNC_getsockopt'
>         (void *) BPF_FUNC_getsockopt;
> 
> Fixes: e043325b3087 ("bpf: Add tests for eBPF file mode")
> Fixes: 6e71b04a8224 ("bpf: Add file mode configuration into bpf maps")
> Fixes: cd86d1fd2102 ("bpf: Adding helper function bpf_getsockops")
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> Acked-by: Daniel Borkmann <daniel@...earbox.net>

Applied, thanks Alexei.