netdev - Re: [PATCH v2 net-next 2/2] ibmvnic: Fix failover error path for non-fatal resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Oct 2017 07:02:55 +0800
From:   kbuild test robot <lkp@...el.com>
To:     John Allen <jallen@...ux.vnet.ibm.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>,
        Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2 net-next 2/2] ibmvnic: Fix failover error path for
 non-fatal resets

Hi John,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/John-Allen/ibmvnic-Update-reset-infrastructure-to-support-tunable-parameters/20171024-062007
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/net//ethernet/ibm/ibmvnic.c: In function '__ibmvnic_reset':
>> drivers/net//ethernet/ibm/ibmvnic.c:1620:26: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
      adapter->reset_done_rc = rc;
      ~~~~~~~~~~~~~~~~~~~~~~~^~~~

vim +/rc +1620 drivers/net//ethernet/ibm/ibmvnic.c

ed651a108 Nathan Fontenot 2017-05-03  1592  
ed651a108 Nathan Fontenot 2017-05-03  1593  static void __ibmvnic_reset(struct work_struct *work)
ed651a108 Nathan Fontenot 2017-05-03  1594  {
ed651a108 Nathan Fontenot 2017-05-03  1595  	struct ibmvnic_rwi *rwi;
ed651a108 Nathan Fontenot 2017-05-03  1596  	struct ibmvnic_adapter *adapter;
ed651a108 Nathan Fontenot 2017-05-03  1597  	struct net_device *netdev;
ed651a108 Nathan Fontenot 2017-05-03  1598  	u32 reset_state;
ed651a108 Nathan Fontenot 2017-05-03  1599  	int rc;
ed651a108 Nathan Fontenot 2017-05-03  1600  
ed651a108 Nathan Fontenot 2017-05-03  1601  	adapter = container_of(work, struct ibmvnic_adapter, ibmvnic_reset);
ed651a108 Nathan Fontenot 2017-05-03  1602  	netdev = adapter->netdev;
ed651a108 Nathan Fontenot 2017-05-03  1603  
ed651a108 Nathan Fontenot 2017-05-03  1604  	mutex_lock(&adapter->reset_lock);
ed651a108 Nathan Fontenot 2017-05-03  1605  	adapter->resetting = true;
ed651a108 Nathan Fontenot 2017-05-03  1606  	reset_state = adapter->state;
ed651a108 Nathan Fontenot 2017-05-03  1607  
ed651a108 Nathan Fontenot 2017-05-03  1608  	rwi = get_next_rwi(adapter);
ed651a108 Nathan Fontenot 2017-05-03  1609  	while (rwi) {
ed651a108 Nathan Fontenot 2017-05-03  1610  		rc = do_reset(adapter, rwi, reset_state);
ed651a108 Nathan Fontenot 2017-05-03  1611  		kfree(rwi);
73daa92e4 John Allen      2017-10-23  1612  		if (rc && rc != IBMVNIC_INIT_FAILED)
ed651a108 Nathan Fontenot 2017-05-03  1613  			break;
ed651a108 Nathan Fontenot 2017-05-03  1614  
ed651a108 Nathan Fontenot 2017-05-03  1615  		rwi = get_next_rwi(adapter);
ed651a108 Nathan Fontenot 2017-05-03  1616  	}
ed651a108 Nathan Fontenot 2017-05-03  1617  
ce7a66cc8 John Allen      2017-10-23  1618  	if (adapter->wait_for_reset) {
ce7a66cc8 John Allen      2017-10-23  1619  		adapter->wait_for_reset = false;
ce7a66cc8 John Allen      2017-10-23 @1620  		adapter->reset_done_rc = rc;
ce7a66cc8 John Allen      2017-10-23  1621  		complete(&adapter->reset_done);
ce7a66cc8 John Allen      2017-10-23  1622  	}
ce7a66cc8 John Allen      2017-10-23  1623  
ed651a108 Nathan Fontenot 2017-05-03  1624  	if (rc) {
d1cf33d93 Nathan Fontenot 2017-08-08  1625  		netdev_dbg(adapter->netdev, "Reset failed\n");
ed651a108 Nathan Fontenot 2017-05-03  1626  		free_all_rwi(adapter);
6d0af07d5 Wei Yongjun     2017-05-18  1627  		mutex_unlock(&adapter->reset_lock);
ed651a108 Nathan Fontenot 2017-05-03  1628  		return;
ed651a108 Nathan Fontenot 2017-05-03  1629  	}
ed651a108 Nathan Fontenot 2017-05-03  1630  
ed651a108 Nathan Fontenot 2017-05-03  1631  	adapter->resetting = false;
ed651a108 Nathan Fontenot 2017-05-03  1632  	mutex_unlock(&adapter->reset_lock);
ed651a108 Nathan Fontenot 2017-05-03  1633  }
ed651a108 Nathan Fontenot 2017-05-03  1634  

:::::: The code at line 1620 was first introduced by commit
:::::: ce7a66cc8fceb75d2a95e5e68d21c1889821ff08 ibmvnic: Update reset infrastructure to support tunable parameters

:::::: TO: John Allen <jallen@...ux.vnet.ibm.com>
:::::: CC: 0day robot <fengguang.wu@...el.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (55120 bytes)