netdev - Re: [PATCH] esp6: remove redundant initialization of esph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Oct 2017 13:21:07 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Colin King <colin.king@...onical.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        "Hideaki YOSHIFUJI" <yoshfuji@...ux-ipv6.org>,
        <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] esp6: remove redundant initialization of esph

On Thu, Oct 19, 2017 at 03:09:47PM +0200, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer esph is being initialized with a value that is never
> read and then being updated.  Remove the redundant initialization
> and move the declaration and initializtion of esph to the local
> code block.
> 
> Cleans up clang warning:
> net/ipv6/esp6.c:562:21: warning: Value stored to 'esph' during its
> initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to ipsec-next, thanks!