netdev - Re: [PATCH] ethernet: cavium: octeon: Switch to using netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Oct 2017 18:38:56 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     steven.hill@...ium.com
Cc:     netdev@...r.kernel.org, david.daney@...ium.com
Subject: Re: [PATCH] ethernet: cavium: octeon: Switch to using
 netdev_info().

From: "Steven J. Hill" <steven.hill@...ium.com>
Date: Mon, 23 Oct 2017 11:43:25 -0500

> @@ -705,14 +705,15 @@ static int octeon_mgmt_ioctl_hwtstamp(struct net_device *netdev,
>  			u64 clock_comp = (NSEC_PER_SEC << 32) /	octeon_get_io_clock_rate();
>  			if (!ptp.s.ptp_en)
>  				cvmx_write_csr(CVMX_MIO_PTP_CLOCK_COMP, clock_comp);
> -			pr_info("PTP Clock: Using sclk reference at %lld Hz\n",
> +			netdev_info(netdev,
> +				"PTP Clock: Using sclk reference at %lld Hz\n",

Please get the argument alignment correct when you make changes like this.

For a function call, the arguments on the second and subsequent line of
arguments must start exactly at the first column after the openning
parenthesis of the call.

You must use the appropriate number of TAB then SPACE characters necessary
to achieve this.

Thank you.