netdev - Re: [PATCH v6 net-next 05/12] gtp: Change to use gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2017 13:35:06 -0600
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Tom Herbert <tom@...ntonium.net>
Cc:     davem@...emloft.net, pablo@...filter.org, laforge@...monks.org,
        aschultz@...p.net, netdev@...r.kernel.org, rohit@...ntonium.net,
        netdev-owner@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v6 net-next 05/12] gtp: Change to use gro_cells

> @@ -611,6 +615,8 @@ static const struct net_device_ops gtp_netdev_ops = 
> {
> 
>  static void gtp_link_setup(struct net_device *dev)
>  {
> +	struct gtp_dev *gtp = netdev_priv(dev);
> +
>  	dev->netdev_ops		= &gtp_netdev_ops;
>  	dev->needs_free_netdev	= true;
> 
> @@ -630,6 +636,8 @@ static void gtp_link_setup(struct net_device *dev)
>  				  sizeof(struct iphdr) +
>  				  sizeof(struct udphdr) +
>  				  sizeof(struct gtp0_header);
> +
> +	gro_cells_init(&gtp->gro_cells, dev);
>  }
> 

Hi Tom

This needs a check in case the initialization failed and moved to 
ndo_init().
Eric spotted a similar bug in rmnet and vxlan.


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project