lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Oct 2017 00:28:43 +1100 From: Julian Calaby <julian.calaby@...il.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net> Cc: linux-wireless <linux-wireless@...r.kernel.org>, netdev <netdev@...r.kernel.org>, Arend Van Spriel <arend.vanspriel@...adcom.com>, Eyal Reizer <eyalr@...com>, Iain Hunter <drhunter95@...il.com>, James Minor <james.minor@...com>, Johannes Berg <johannes.berg@...el.com>, Kalle Valo <kvalo@...eaurora.org>, Maxim Altshul <maxim.altshul@...com>, Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb() Hi Markus, On Mon, Oct 30, 2017 at 7:11 AM, SF Markus Elfring <elfring@...rs.sourceforge.net> wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Sun, 29 Oct 2017 18:38:04 +0100 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> > --- > drivers/net/wireless/ti/wlcore/main.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c > index c346c021b999..48380d48ef09 100644 > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -6551,6 +6549,11 @@ static void wlcore_nvs_cb(const struct firmware *fw, void *context) > out: > release_firmware(fw); > complete_all(&wl->nvs_loading_complete); > + return; > + > +power_off: Name this "out_power_off" to match the other labels. > + wl1271_power_off(wl); > + goto out_free_nvs; Why not put this in front of the out_free_nvs label? It looks weird here. Thanks, -- Julian Calaby Email: julian.calaby@...il.com Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists