netdev - Re: [RFC v2 PATCH 04/11] net: Create and use new helper xfrm_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 01 Nov 2017 11:07:35 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC v2 PATCH 04/11] net: Create and use new helper
 xfrm_dst_child().

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 31 Oct 2017 11:39:22 -0700

> On Tue, 2017-10-31 at 23:10 +0900, David S. Miller wrote:
>> @@ -116,12 +116,14 @@ EXPORT_SYMBOL(dst_alloc);
>>  
>>  struct dst_entry *dst_destroy(struct dst_entry * dst)
>>  {
>> -	struct dst_entry *child;
>> +	struct dst_entry *child = NULL;
>>  
>>  	smp_rmb();
>>  
>> -	child = dst->child;
>> -
>> +#ifdef CONFIG_XFRM
>> +	if (dst->xfrm)
>> +		child = dst->child;
>> +#endif
> 
> 
> Why not using here :
> 
> 	child = xfrm_dst_child(dst);
> 
> This avoid the #ifdef and uses the new helper quite well.

Yep, that makes a lot of sense, thanks for the review(s).