netdev - Re: [Patch net-next] net_sched: check NULL in tcf_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 03 Nov 2017 21:31:32 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, dave.taht@...il.com, jiri@...lanox.com
Subject: Re: [Patch net-next] net_sched: check NULL in tcf_block_put()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu,  2 Nov 2017 17:32:08 -0700

> Callers of tcf_block_put() could pass NULL so
> we can't use block->q before checking if block is
> NULL or not.
> 
> tcf_block_put_ext() callers are fine, it is always
> non-NULL.
> 
> Fixes: 8c4083b30e56 ("net: sched: add block bind/unbind notif. and extended block_get/put")
> Reported-by: Dave Taht <dave.taht@...il.com>
> Cc: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thanks Cong.