netdev - Re: [patch net-next] net: sched: move block offload unbind after all chains are flushed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Nov 2017 07:59:45 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        mlxsw@...lanox.com, alexander.h.duyck@...el.com, kubakici@...pl
Subject: Re: [patch net-next] net: sched: move block offload unbind after all
 chains are flushed

Fri, Nov 03, 2017 at 07:47:44AM CET, davem@...emloft.net wrote:
>From: Jiri Pirko <jiri@...nulli.us>
>Date: Thu,  2 Nov 2017 15:07:01 +0100
>
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Currently, the offload unbind is done before the chains are flushed.
>> That causes driver to unregister block callback before it can get all
>> the callback calls done during flush, leaving the offloaded tps inside
>> the HW. So fix the order to prevent this situation and restore the
>> original behaviour.
>> 
>> Reported-by: Alexander Duyck <alexander.duyck@...il.com>
>> Reported-by: Jakub Kicinski <kubakici@...pl>
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>
>I'm pretty sure this was my fault during the merge, I had to pick
>whether to do it before or after the offload unbind and I picked the
>latter.

I also had it wrong in the original commit 8c4083b30e56fc71b0e94c26374b32d95d5ea461

>
>Applied, thank you.

Thanks.