netdev - Re: [PATCH 20/21] phonet: exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 Nov 2017 21:16:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vasily Averin <vvs@...tuozzo.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Remi Denis-Courmont <courmisch@...il.com>
Subject: Re: [PATCH 20/21] phonet: exit_net cleanup check added

Hi Vasily,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on v4.14-rc7 next-20171103]
[cannot apply to net-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vasily-Averin/exit_net-checks-for-objects-initialized-in-net_init-hook/20171105-201757
config: x86_64-randconfig-x018-201745 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bug.h:82:0,
                    from include/linux/bug.h:5,
                    from include/linux/jump_label.h:187,
                    from include/linux/once.h:6,
                    from include/linux/random.h:11,
                    from include/linux/net.h:22,
                    from net/phonet/pn_dev.c:27:
   net/phonet/pn_dev.c: In function 'phonet_exit_net':
>> net/phonet/pn_dev.c:335:20: error: 'pnn' undeclared (first use in this function)
     WARN(!list_empty(&pnn->pndevs.list),
                       ^
   include/asm-generic/bug.h:117:25: note: in definition of macro 'WARN'
     int __ret_warn_on = !!(condition);    \
                            ^~~~~~~~~
   net/phonet/pn_dev.c:335:20: note: each undeclared identifier is reported only once for each function it appears in
     WARN(!list_empty(&pnn->pndevs.list),
                       ^
   include/asm-generic/bug.h:117:25: note: in definition of macro 'WARN'
     int __ret_warn_on = !!(condition);    \
                            ^~~~~~~~~

vim +/pnn +335 net/phonet/pn_dev.c

   331	
   332	static void __net_exit phonet_exit_net(struct net *net)
   333	{
   334		remove_proc_entry("phonet", net->proc_net);
 > 335		WARN(!list_empty(&pnn->pndevs.list),
   336		     "net %p exit: phonet pndevs.list is not empty\n", net);
   337	}
   338	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (24640 bytes)