netdev - Re: [net-next v2 1/1] tipc: improve link resiliency when rps is activated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2017 15:36:33 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next v2 1/1] tipc: improve link resiliency when rps is
 activated

From: Jon Maloy <jon.maloy@...csson.com>
Date: Wed, 8 Nov 2017 09:59:26 +0100

> Currently, the TIPC RPS dissector is based only on the incoming packets'
> source node address, hence steering all traffic from a node to the same
> core. We have seen that this makes the links vulnerable to starvation
> and unnecessary resets when we turn down the link tolerance to very low
> values.
> 
> To reduce the risk of this happening, we exempt probe and probe replies
> packets from the convergence to one core per source node. Instead, we do
> the opposite, - we try to diverge those packets across as many cores as
> possible, by randomizing the flow selector key.
> 
> To make such packets identifiable to the dissector, we add a new
> 'is_keepalive' bit to word 0 of the LINK_PROTOCOL header. This bit is
> set both for PROBE and PROBE_REPLY messages, and only for those.
> 
> It should be noted that these packets are not part of any flow anyway,
> and only constitute a minuscule fraction of all packets sent across a
> link. Hence, there is no risk that this will affect overall performance.
> 
> Acked-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks.