netdev - Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2017 19:07:52 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     u9012063@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

From: William Tu <u9012063@...il.com>
Date: Wed,  8 Nov 2017 16:13:02 -0800

> +static void erspan_build_header(struct sk_buff *skb,
> +				__be32 id, u32 index,
> +				bool truncate, bool is_ipv4)
> +{

Please do not put large non-inline functions into header files.