netdev - Re: [PATCH] net: dsa: lan9303: correctly check return value of devm_gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Nov 2017 21:35:22 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     bianpan2016@....com
Cc:     andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] net: dsa: lan9303: correctly check return value of
 devm_gpiod_get_optional

From: Pan Bian <bianpan2016@....com>
Date: Sun, 12 Nov 2017 23:38:09 +0800

> Function devm_gpiod_get_optional() returns an ERR_PTR on failure. Its
> return value should not be validated by a NULL check. Instead, use IS_ERR.
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Applied.