lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Nov 2017 14:19:36 +0900 (KST) From: David Miller <davem@...emloft.net> To: linyu.yuan@...ia-sbell.com Cc: cugyly@....com, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: assign err to 0 at begin in do_setlink() function From: "Yuan, Linyu (NSB - CN/Shanghai)" <linyu.yuan@...ia-sbell.com> Date: Wed, 15 Nov 2017 05:15:35 +0000 > > >> -----Original Message----- >> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] >> On Behalf Of David Miller >> Sent: Wednesday, November 15, 2017 1:08 PM >> To: cugyly@....com >> Cc: netdev@...r.kernel.org; Yuan, Linyu (NSB - CN/Shanghai) >> Subject: Re: [PATCH net-next] net: assign err to 0 at begin in do_setlink() >> function >> >> From: yuan linyu <cugyly@....com> >> Date: Tue, 14 Nov 2017 22:30:59 +0800 >> >> > From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn> >> > >> > each netlink attribute have proper process when error happen, >> > when exit on attribute process, it implies that no error, >> > so err = 0; is useless. >> > >> > assign err = 0; at beginning if all attributes not set. >> > >> > Signed-off-by: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn> >> >> This change is not correct. >> >> The IFLA_VF_PORTS code block can finish with err set non-zero. > > Do you mean this block can return err = -EOPNOTSUPP; ? > It means nla_for_each_nested() in this block will never enter, right ? Yes, that is what I mean.
Powered by blists - more mailing lists