netdev - Re: [PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Nov 2017 19:49:50 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     bjorn@...k.no
Cc:     netdev@...r.kernel.org, oliver@...kum.org,
        ben.hutchings@...ethink.co.uk, linux-usb@...r.kernel.org,
        mrkiko.rs@...il.com, christian@...ton.org
Subject: Re: [PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

From: Bjørn Mork <bjorn@...k.no>
Date: Wed, 15 Nov 2017 09:35:02 +0100

> The GetNtbFormat and SetNtbFormat requests operate on 16 bit little
> endian values. We get away with ignoring this most of the time, because
> we only care about USB_CDC_NCM_NTB16_FORMAT which is 0x0000.  This
> fails for USB_CDC_NCM_NTB32_FORMAT.
> 
> Fix comparison between LE value from device and constant by converting
> the constant to LE.
> 
> Reported-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> Fixes: 2b02c20ce0c2 ("cdc_ncm: Set NTB format again after altsetting switch for Huawei devices")
> Cc: Enrico Mioso <mrkiko.rs@...il.com>
> Cc: Christian Panton <christian@...ton.org>
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Applied and queued up for -stable, thanks.