netdev - Re: [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Nov 2017 21:33:45 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, hau@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 19 Nov 2017 11:09:58 +0100

> Name of functions rtl_w0w1_eri and rtl_w0w1_phy is somewhat misleading
> regarding order of arguments. One could assume that w0w1 means
> argument with bits to be reset comes before argument with bits to set.
> However this is not the case.
> So fix the order of arguments in several statements.
> 
> In addition fix EEE advertisement. The current code resets the bits
> for 100BaseT and 1000BaseT EEE advertisement what is not what we want.
> 
> I have a little of a hard time to find a proper "Fixes" line as the
> issue seems to have been there forever (at least it existed already
> when the driver was moved to the current place in 2011).
> 
> The patch was tested on a Zotac Mini-PC with a RTL8111E-VL chip.
> Before the patch EEE was disabled, now it's properly advertised and
> works fine.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.