netdev - Re: [PATCH net] net: ipv6: Fixup device for anycast routes during copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Nov 2017 01:35:52 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ipv6: Fixup device for anycast routes during
 copy

From: David Ahern <dsahern@...il.com>
Date: Tue, 21 Nov 2017 07:08:57 -0800

> Florian reported a breakage with anycast routes due to commit
> 4832c30d5458 ("net: ipv6: put host and anycast routes on device with
> address"). Prior to this commit anycast routes were added against the
> loopback device causing repetitive route entries with no insight into
> why they existed. e.g.:
>   $ ip -6 ro ls  table local type anycast
>   anycast 2001:db8:1:: dev lo proto kernel metric 0 pref medium
>   anycast 2001:db8:2:: dev lo proto kernel metric 0 pref medium
>   anycast fe80:: dev lo proto kernel metric 0 pref medium
>   anycast fe80:: dev lo proto kernel metric 0 pref medium
> 
> The point of commit 4832c30d5458 is to add the routes using the device
> with the address which is causing the route to be added. e.g.,:
>   $ ip -6 ro ls  table local type anycast
>   anycast 2001:db8:1:: dev eth1 proto kernel metric 0 pref medium
>   anycast 2001:db8:2:: dev eth2 proto kernel metric 0 pref medium
>   anycast fe80:: dev eth2 proto kernel metric 0 pref medium
>   anycast fe80:: dev eth1 proto kernel metric 0 pref medium
> 
> For traffic to work as it did before, the dst device needs to be switched
> to the loopback when the copy is created similar to local routes.
> 
> Fixes: 4832c30d5458 ("net: ipv6: put host and anycast routes on device with address")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks!