netdev - Re: [PATCH 1/2] net: phy: core: use genphy version of callbacks read_status and config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Nov 2017 15:59:34 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     f.fainelli@...il.com, andrew@...n.ch, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: phy: core: use genphy version of callbacks
 read_status and config_aneg per default

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 29 Nov 2017 21:47:16 +0100

> Am 15.11.2017 um 22:56 schrieb Florian Fainelli:
>> On 11/15/2017 01:42 PM, Heiner Kallweit wrote:
>>> read_status and config_aneg are the only mandatory callbacks and most
>>> of the time the generic implementation is used by drivers.
>>> So make the core fall back to the generic version if a driver doesn't
>>> implement the respective callback.
>>>
>>> Also currently the core doesn't seem to verify that drivers implement
>>> the mandatory calls. If a driver doesn't do so we'd just get a NPE.
>> 
>> Right, which is not an unusual way to signal that something is mandatory.
>> 
>>> With this patch this potential issue doesn't exit any longer.
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>> 
>> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>> 
>> Note that net-next is closed at the moment, so you will have to resubmit
>> this when the tree opens back again.
>> 
> I see that the two patches have status "deferred" in patchwork.
> So do I have to actually resubmit or are they going to be be picked up
> from patchwork?

You must resubmit when the net-next tree opens back up.