netdev - Re: [PATCH net] net: mvpp2: allocate zeroed tx descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Nov 2017 09:14:45 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     antoine.tenart@...e-electrons.com
Cc:     ymarkman@...vell.com, gregory.clement@...e-electrons.com,
        thomas.petazzoni@...e-electrons.com,
        miquel.raynal@...e-electrons.com, nadavh@...vell.com,
        mw@...ihalf.com, stefanc@...vell.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: mvpp2: allocate zeroed tx descriptors

From: Antoine Tenart <antoine.tenart@...e-electrons.com>
Date: Thu, 30 Nov 2017 10:49:46 +0100

> From: Yan Markman <ymarkman@...vell.com>
> 
> Reserved and unused fields in the Tx descriptors should be 0. The PPv2
> driver doesn't clear them at run-time (for performance reasons) but
> these descriptors aren't zeroed when allocated, which can lead to
> unpredictable behaviors. This patch fixes this by using
> dma_zalloc_coherent instead of dma_alloc_coherent.
> 
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> Signed-off-by: Yan Markman <ymarkman@...vell.com>
> [Antoine: commit message]
> Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com>

Applied, thank you.