netdev - Re: [PATCH net] tcp: remove buggy call to tcp_v6_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Nov 2017 10:22:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: remove buggy call to tcp_v6_restore_cb()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 29 Nov 2017 17:43:57 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> tcp_v6_send_reset() expects to receive an skb with skb->cb[] layout as
> used in TCP stack.
> MD5 lookup uses tcp_v6_iif() and tcp_v6_sdif() and thus
> TCP_SKB_CB(skb)->header.h6
> 
> This patch probably fixes RST packets sent on behalf of a timewait md5
> ipv6 socket.
> 
> Before Florian patch, tcp_v6_restore_cb() was needed before jumping to
> no_tcp_socket label.
> 
> Fixes: 271c3b9b7bda ("tcp: honour SO_BINDTODEVICE for TW_RST case too")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable.