lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Nov 2017 08:51:21 +0000 From: Yan Markman <ymarkman@...vell.com> To: Russell King - ARM Linux <linux@...linux.org.uk> CC: Antoine Tenart <antoine.tenart@...e-electrons.com>, "andrew@...n.ch" <andrew@...n.ch>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "davem@...emloft.net" <davem@...emloft.net>, "gregory.clement@...e-electrons.com" <gregory.clement@...e-electrons.com>, "thomas.petazzoni@...e-electrons.com" <thomas.petazzoni@...e-electrons.com>, "miquel.raynal@...e-electrons.com" <miquel.raynal@...e-electrons.com>, "Nadav Haklai" <nadavh@...vell.com>, "mw@...ihalf.com" <mw@...ihalf.com>, "Stefan Chulski" <stefanc@...vell.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect The phylink_stop is called before phylink_disconnect_phy You could see in mvpp2.c: mvpp2_stop_dev() { phylink_stop(port->phylink); } mvpp2_stop() { mvpp2_stop_dev(port); phylink_disconnect_phy(port->phylink); } .ndo_stop = mvpp2_stop, -----Original Message----- From: Russell King - ARM Linux [mailto:linux@...linux.org.uk] Sent: Wednesday, November 29, 2017 11:21 PM To: Yan Markman <ymarkman@...vell.com> Cc: Antoine Tenart <antoine.tenart@...e-electrons.com>; andrew@...n.ch; f.fainelli@...il.com; davem@...emloft.net; gregory.clement@...e-electrons.com; thomas.petazzoni@...e-electrons.com; miquel.raynal@...e-electrons.com; Nadav Haklai <nadavh@...vell.com>; mw@...ihalf.com; Stefan Chulski <stefanc@...vell.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org Subject: Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect On Wed, Nov 29, 2017 at 09:06:56PM +0000, Yan Markman wrote: > The attached p21 patch doesn't change anything. > But another one from the mail-text is good > void phylink_disconnect_phy(struct phylink *pl) > + pl->phy_state.link = false; > > There still (not for my MRVL-PP2) problem: > It is expected that on ifconfig-down the callback > pl->ops->mac_link_down(ndev, pl->link_an_mode); would be called, but > it isn't Are you calling phylink_stop() or are you just calling phylink_disconnect() ? You must call phylink_stop() prior to phylink_disconnect(). This probably explains why the p21 patch did nothing. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
Powered by blists - more mailing lists