lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Dec 2017 07:39:04 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Cong Wang <xiyou.wangcong@...il.com> Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>, Jiri Pirko <jiri@...lanox.com>, Jamal Hadi Salim <jhs@...atatu.com> Subject: Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev() Sat, Dec 02, 2017 at 08:53:20PM CET, xiyou.wangcong@...il.com wrote: >On Sat, Dec 2, 2017 at 11:47 AM, Cong Wang <xiyou.wangcong@...il.com> wrote: >> On Sat, Dec 2, 2017 at 12:57 AM, Jiri Pirko <jiri@...nulli.us> wrote: >>> Good. Please also use m->tcfm_dev->ifindex in tcf_mirred_dump and >>> tcf_mirred_ifindex. Then you can remove tcfm_ifindex completely. >> >> Sounds good. Will send v2. > >Hold on, m->tcfm_dev could be NULL, so we can't just def it here. > >I think we can just use 0 when it is NULL: > >.ifindex = m->tcfm_dev ? m->tcfm_dev->ifindex : 0, > >This also "fixes" the garbage ifindex dump when the target device is gone. Sounds fine.
Powered by blists - more mailing lists