netdev - Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Dec 2017 10:11:38 -0800
From:   Michael Chan <michael.chan@...adcom.com>
To:     Or Gerlitz <gerlitz.or@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.

On Mon, Dec 4, 2017 at 8:35 AM, Or Gerlitz <gerlitz.or@...il.com> wrote:
> On Mon, Dec 4, 2017 at 1:12 PM, Michael Chan <michael.chan@...adcom.com> wrote:
>> Advertise NETIF_F_GRO_HW if hardware GRO is supported.  Turn on or off
>> hardware GRO based on NETIF_F_GRO_HW.
>
> So the patch only deals with advertisement biz.. and I even failed to
> find a place where you arm
> something in the FW... so this just works OOB, all your buffers && skb
> logic && FW setup are fully
> ready for that? also, nothing you need to put differently on the SKB
> for HW GRO completions?
> can you explain this little further or it's all in your netdev slides...
>

All the logic is already in these 3 drivers in the tree.  You can see
the additional logic in any of these drivers.  It's just that these
drivers have been using NETIF_F_GRO to turn on this mode in
hardware/firmware.  So these patches are just to switch over to use
the new flag to turn on this mode so that it can be independently
turned on or off.