netdev - Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv4 pkts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 06 Dec 2017 14:44:11 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, sgoutham@...ium.com,
        aleksey.makarov@...iga.com, edumazet@...gle.com
Subject: Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for
 IPv4 pkts

From: Florian Westphal <fw@...len.de>
Date: Wed,  6 Dec 2017 01:04:50 +0100

> Offload IP header checksum to NIC.
> 
> This fixes a previous patch which disabled checksum offloading
> for both IPv4 and IPv6 packets.  So L3 checksum offload was
> getting disabled for IPv4 pkts.  And HW is dropping these pkts
> for some reason.
> 
> Without this patch, IPv4 TSO appears to be broken:
> 
> WIthout this patch I get ~16kbyte/s, with patch close to 2mbyte/s
> when copying files via scp from test box to my home workstation.
> 
> Looking at tcpdump on sender it looks like hardware drops IPv4 TSO skbs.
> This patch restores performance for me, ipv6 looks good too.
> 
> Fixes: fa6d7cb5d76c ("net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts")
> Cc: Sunil Goutham <sgoutham@...ium.com>
> Cc: Aleksey Makarov <aleksey.makarov@...iga.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied and queued up for -stable, thanks Florian.