netdev - Re: [PATCH net 2/4] net: aquantia: Fix hardware DMA stream overload on large MRRS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2017 12:56:15 +0300
From:   Igor Russkikh <igor.russkikh@...antia.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, darcari@...hat.com,
        pavel.belous@...antia.com, Nadezhda.Krupnina@...antia.com,
        simon.edelhaus@...antia.com
Subject: Re: [PATCH net 2/4] net: aquantia: Fix hardware DMA stream overload
 on large MRRS

Hi David!

>> +#define pci_reg_control6_adr 0x1014u
>> +
> CPP macros, especially those which define register numbers or bit
> valus, should never use lowercase.  They should always use uppercase
> names.
>
> This is a coding style convention we use in the entire kernel which
> makes it easy to visually see whether something is a bonafide C
> symbol or a CPP macro.

Totally agree on that. I honestly not aware of the history why it was done in lowercase.
I'm now preparing a set of commits for new hardware revisions support, I can queue this task there as well.

Or, if you prefer, I may add this low to uppercase conversion patch into this patchset and resubmit.

BR, Igor