[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 12 Dec 2017 08:54:25 -0800
From: Alexei Starovoitov <ast@...com>
To: Peter Zijlstra <peterz@...radead.org>, Yonghong Song <yhs@...com>
CC: <daniel@...earbox.net>, <netdev@...r.kernel.org>,
<kernel-team@...com>
Subject: Re: [PATCH net-next v4 1/2] bpf/tracing: allow user space to query
prog array on the same tp
On 12/12/17 1:03 AM, Peter Zijlstra wrote:
> On Mon, Dec 11, 2017 at 11:39:02AM -0800, Yonghong Song wrote:
>> The usage:
>> struct perf_event_query_bpf *query = malloc(...);
>> query.ids_len = ids_len;
>> err = ioctl(pmu_efd, PERF_EVENT_IOC_QUERY_BPF, &query);
>
> You didn't spot the fixes to your changelog ;-) The above should read
> something like:
>
> struct perf_event_query_bpf *query =
> malloc(sizeof(*query) + sizeof(u32) * ids_len);
> query->ids_len = ids_len;
> err = ioctl(pmu_efd, PERF_EVENT_IOC_QUERY_BPF, query);
sure. I fixed up this nit in commit log of patch 1 and in test_progs.c
of patch 2.
Powered by blists - more mailing lists