netdev - Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Dec 2017 21:48:11 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     Jassi Brar <jassisinghbrar@...il.com>,
        "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd.bergmann@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

> > +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv)
> > +{
> > +       struct phy_device *phydev = priv->ndev->phydev;
> > +       u32 value = 0;
> > +
> > +       value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON :
> > +                                NETSEC_GMAC_MCR_REG_HALF_DUPLEX_COMMON;
> > +
> > +       if (phydev->speed != SPEED_1000)
> > +               value |= NETSEC_MCR_PS;
> > +
> > +       if (priv->phy_interface != PHY_INTERFACE_MODE_GMII &&
> > +           phydev->speed == SPEED_100)
> > +               value |= NETSEC_GMAC_MCR_REG_FES;
> > +
> > +       value |= NETSEC_GMAC_MCR_REG_CST | NETSEC_GMAC_MCR_REG_JE;
> > +
> > +       if (priv->phy_interface == PHY_INTERFACE_MODE_RGMII)
> > +               value |= NETSEC_GMAC_MCR_REG_IBN;

phy_interface_mode_is_rgmii() ??

      Andrew