netdev - Re: [PATCHv2 net-next 04/15] net: sched: sch: add extack for init callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 17 Dec 2017 03:08:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Alexander Aring <aring@...atatu.com>
Cc:     kbuild-all@...org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, davem@...emloft.net, netdev@...r.kernel.org,
        kernel@...atatu.com, Alexander Aring <aring@...atatu.com>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCHv2 net-next 04/15] net: sched: sch: add extack for init
 callback

Hi Alexander,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Alexander-Aring/net-sched-sch-introduce-extack-support/20171217-015839
config: i386-randconfig-a0-201750 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

>> net//sched/sch_atm.c:679:2: warning: initialization from incompatible pointer type
     .init  = atm_tc_init,
     ^
   net//sched/sch_atm.c:679:2: warning: (near initialization for 'atm_qdisc_ops.init')

vim +679 net//sched/sch_atm.c

^1da177e4 Linus Torvalds  2005-04-16  671  
20fea08b5 Eric Dumazet    2007-11-14  672  static struct Qdisc_ops atm_qdisc_ops __read_mostly = {
^1da177e4 Linus Torvalds  2005-04-16  673  	.cl_ops		= &atm_class_ops,
^1da177e4 Linus Torvalds  2005-04-16  674  	.id		= "atm",
^1da177e4 Linus Torvalds  2005-04-16  675  	.priv_size	= sizeof(struct atm_qdisc_data),
^1da177e4 Linus Torvalds  2005-04-16  676  	.enqueue	= atm_tc_enqueue,
^1da177e4 Linus Torvalds  2005-04-16  677  	.dequeue	= atm_tc_dequeue,
8e3af9789 Jarek Poplawski 2008-10-31  678  	.peek		= atm_tc_peek,
^1da177e4 Linus Torvalds  2005-04-16 @679  	.init		= atm_tc_init,
^1da177e4 Linus Torvalds  2005-04-16  680  	.reset		= atm_tc_reset,
^1da177e4 Linus Torvalds  2005-04-16  681  	.destroy	= atm_tc_destroy,
^1da177e4 Linus Torvalds  2005-04-16  682  	.dump		= atm_tc_dump,
^1da177e4 Linus Torvalds  2005-04-16  683  	.owner		= THIS_MODULE,
^1da177e4 Linus Torvalds  2005-04-16  684  };
^1da177e4 Linus Torvalds  2005-04-16  685  

:::::: The code at line 679 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29290 bytes)