netdev - Re: [PATCH v4 net-next 6/6] ila: Route notify (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Date:   Sat, 16 Dec 2017 23:02:13 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Tom Herbert <tom@...ntonium.net>
cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        rohit@...ntonium.net, davem@...emloft.net, kbuild-all@...org
Subject: Re: [PATCH v4 net-next 6/6] ila: Route notify (fwd)

Hello,

Another tab appears to be needed on line 358.

julia

---------- Forwarded message ----------
Date: Sun, 17 Dec 2017 05:42:17 +0800
From: kbuild test robot <fengguang.wu@...el.com>
To: kbuild@...org
Cc: Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH v4 net-next 6/6] ila: Route notify

CC: kbuild-all@...org
In-Reply-To: <20171215182800.10248-7-tom@...ntonium.net>
References: <20171215182800.10248-7-tom@...ntonium.net>
TO: Tom Herbert <tom@...ntonium.net>
CC: davem@...emloft.net
CC: netdev@...r.kernel.org, roopa@...ulusnetworks.com, rohit@...ntonium.net, Tom Herbert <tom@...ntonium.net>

Hi Tom,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Tom-Herbert/net-ILA-notification-mechanism-and-fixes/20171217-041013
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

>> net/ipv6/ila/ila_lwt.c:358:2-23: code aligned with following code on line 360

# https://github.com/0day-ci/linux/commit/bdefe11e33bb3662a60476ea17663189974227a0
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout bdefe11e33bb3662a60476ea17663189974227a0
vim +358 net/ipv6/ila/ila_lwt.c

79ff2fc3 net/ipv6/ila/ila_lwt.c Tom Herbert     2016-10-14  347
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  348  static int ila_fill_encap_info(struct sk_buff *skb,
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  349  			       struct lwtunnel_state *lwtstate)
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  350  {
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  351  	struct ila_params *p = ila_params_lwtunnel(lwtstate);
fddb231e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-11-05  352  	struct ila_lwt *ilwt = ila_lwt_lwtunnel(lwtstate);
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  353
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  354  	if (ilwt->xlat) {
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  355  		if (nla_put_u64_64bit(skb, ILA_ATTR_LOCATOR,
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  356  				      (__force u64)p->locator.v64,
f13a82d8 net/ipv6/ila/ila_lwt.c Nicolas Dichtel 2016-04-25  357  				      ILA_ATTR_PAD))
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17 @358  		goto nla_put_failure;
70d5aef4 net/ipv6/ila/ila_lwt.c Tom Herbert     2017-11-05  359
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15 @360  		if (nla_put_u8(skb, ILA_ATTR_CSUM_MODE,
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  361  			       (__force u8)p->csum_mode))
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  362  			goto nla_put_failure;
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  363
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  364  		if (nla_put_u8(skb, ILA_ATTR_IDENT_TYPE,
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  365  			       (__force u8)p->ident_type))
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  366  			goto nla_put_failure;
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  367  	}
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  368
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  369  	if (nla_put_u8(skb, ILA_ATTR_HOOK_TYPE, ilwt->hook_type))
90bfe662 net/ipv6/ila/ila_lwt.c Tom Herbert     2016-04-23  370  		goto nla_put_failure;
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  371
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  372  	if (ilwt->notify & ILA_NOTIFY_DST)
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  373  		if (nla_put_flag(skb, ILA_ATTR_NOTIFY_DST))
70d5aef4 net/ipv6/ila/ila_lwt.c Tom Herbert     2017-11-05  374  			goto nla_put_failure;
70d5aef4 net/ipv6/ila/ila_lwt.c Tom Herbert     2017-11-05  375
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  376  	if (ilwt->notify & ILA_NOTIFY_SRC)
bdefe11e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-12-15  377  		if (nla_put_flag(skb, ILA_ATTR_NOTIFY_SRC))
fddb231e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-11-05  378  			goto nla_put_failure;
fddb231e net/ipv6/ila/ila_lwt.c Tom Herbert     2017-11-05  379
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  380  	return 0;
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  381
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  382  nla_put_failure:
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  383  	return -EMSGSIZE;
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  384  }
65d7ab8d net/ipv6/ila.c         Tom Herbert     2015-08-17  385

:::::: The code at line 358 was first introduced by commit
:::::: 65d7ab8de582bc668e3dabb6ff48f750098a6e78 net: Identifier Locator Addressing module

:::::: TO: Tom Herbert <tom@...bertland.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation