netdev - Re: [PATCH net-next 14/17] net: hns3: add Asym Pause support to phy default features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Dec 2017 12:07:11 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Lipeng <lipeng321@...wei.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, salil.mehta@...wei.com
Subject: Re: [PATCH net-next 14/17] net: hns3: add Asym Pause support to phy
 default features

Hello!

On 12/18/2017 12:31 PM, Lipeng wrote:

> From: Fuyun Liang <liangfuyun1@...wei.com>
> 
> commit c4fb2cdf575d (net: hns3: fix a bug for phy supported feature
> initialization) adds default supported features for phy, but our hardware

    Ten cited commit's summary needs to be enclosed in (""), not just ()...

> also supports Asym Pause. This patch adds Asym Pause support to phy
> default features to prevent Asym Pause can not be advertised when the phy
> negotiates flow control.
> 
> Fixes: c4fb2cdf575d (net: hns3: fix a bug for phy supported feature initialization)

    Here as well...

> Signed-off-by: Fuyun Liang <liangfuyun1@...wei.com>
> Signed-off-by: Lipeng <lipeng321@...wei.com>
[...]

MBR, Sergei