netdev - Re: xfrm: Reinject transport-mode packets through tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Dec 2017 13:23:41 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     <netdev@...r.kernel.org>
Subject: Re: xfrm: Reinject transport-mode packets through tasklet

On Fri, Dec 15, 2017 at 04:40:44PM +1100, Herbert Xu wrote:
> This is an old bugbear of mine:
> 
> https://www.mail-archive.com/netdev@vger.kernel.org/msg03894.html
> 
> By crafting special packets, it is possible to cause recursion
> in our kernel when processing transport-mode packets at levels
> that are only limited by packet size.
> 
> The easiest one is with DNAT, but an even worse one is where
> UDP encapsulation is used in which case you just have to insert
> an UDP encapsulation header in between each level of recursion.
> 
> This patch avoids this problem by reinjecting tranport-mode packets
> through a tasklet.
> 
> Fixes: b05e106698d9 ("[IPV4/6]: Netfilter IPsec input hooks")
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied to the ipsec tree, thanks Herbert!