netdev - [PATCH net 0/2] cls_bpf: fix offload state tracking with block callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Dec 2017 13:32:12 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     netdev@...r.kernel.org
Cc:     daniel@...earbox.net, jiri@...nulli.us, oss-drivers@...ronome.com,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: [PATCH net 0/2] cls_bpf: fix offload state tracking with block callbacks

Hi!

After introduction of block callbacks classifiers can no longer track
offload state.  cls_bpf used to do that in an attempt to move common
code from drivers to the core.  Remove that functionality and fix
drivers.

The user-visible bug this is fixing is that trying to offload a second
filter would trigger a spurious DESTROY and in turn disable the already
installed one.

Jakub Kicinski (2):
  cls_bpf: fix offload assumptions after callback conversion
  nfp: bpf: keep track of the offloaded program

 drivers/net/ethernet/netronome/nfp/bpf/main.c | 55 ++++++++++++----
 drivers/net/ethernet/netronome/nfp/bpf/main.h |  8 +++
 include/net/pkt_cls.h                         |  5 +-
 net/sched/cls_bpf.c                           | 93 +++++++++++----------------
 4 files changed, 92 insertions(+), 69 deletions(-)

-- 
2.15.1